Skip to content

feat(ui-color-picker): rework ColorPicker#2439

Open
ToMESSKa wants to merge 1 commit intov12from
INSTUI-4789-color-picker-rework2
Open

feat(ui-color-picker): rework ColorPicker#2439
ToMESSKa wants to merge 1 commit intov12from
INSTUI-4789-color-picker-rework2

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 10, 2026

INSTUI-4789

ISSUE:

  • ColorPicker, ColorContrast, ColorIndicator, ColorPixer and ColorPreset need to be migrated to the new theming system

TEST PLAN:

  • check if the components work the same as before in v1 (these are token-only components)
  • check if the components and the examples work in v2 (especially the dark theme)
  • check if all necessary the imports are renamed to v11_6 in v1
  • check if all necessary the imports are renamed to latest in v2
  • check if the test files are removed from the v1
  • check if the right imports are used in packages/ui-color-picker/src/exports/b.ts and packages/ui-color-picker/src/exports/a.ts
  • check if the packages/ui-color-picker/package.json uses the correct versioning
  • check if the renamed or removed tokes are documented in the upgrade guide
  • check if the index.ts files use withStyle instead of withStyleLegacy

@ToMESSKa ToMESSKa self-assigned this Mar 10, 2026
Comment on lines +572 to +575
// const showRebrandThemes =
// this.state.showMinorVersionSelector &&
// this.state.selectedMinorVersion !== 'v11_6'
const showRebrandThemes = true // TODO temp workaround
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix to see the v2 in the PR preview

Comment on lines +77 to +80
"types": "./types/exports/b.d.ts",
"import": "./es/exports/b.js",
"require": "./lib/exports/b.js",
"default": "./es/exports/b.js"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix to see the v2 in the PR preview

@github-actions
Copy link

github-actions bot commented Mar 10, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2439/

Built to branch gh-pages at 2026-03-11 15:20 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa
Copy link
Contributor Author

@hajnaldo please don't forget to review all these components ColorPicker, ColorContrast, ColorIndicator, ColorPixer and ColorPreset

INSTUI-4789

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ToMESSKa ToMESSKa force-pushed the INSTUI-4789-color-picker-rework2 branch from d04fc91 to 732c170 Compare March 11, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant